Change asyncio detection to use get_running_loop#36
Closed
tapetersen wants to merge 4 commits intopython-trio:masterfrom
Closed
Change asyncio detection to use get_running_loop#36tapetersen wants to merge 4 commits intopython-trio:masterfrom
tapetersen wants to merge 4 commits intopython-trio:masterfrom
Conversation
tapetersen
force-pushed
the
master
branch
2 times, most recently
from
f97b8c7 to
82e364b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 96.51% 90.65% -5.86%
==========================================
Files 4 4
Lines 86 107 +21
Branches 17 16 -1
==========================================
+ Hits 83 97 +14
- Misses 2 9 +7
Partials 1 1
|
Author
|
Not sure about backwards compatibility guarantees. I think the old part with Task could be removed if we don't need to support <3.7 . The windows errors in CI I don't really understand but it feels like they aren't related to my code. |
Member
|
Thanks for the PR! Closing in favor of #39 which is a bit more streamlined, but we're planning to adopt these semantics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to solve #35
Not sure if the other tests are still needed (get_running_loop appeared in 3.7).
Added a test to ensure this works and could add more if needed.
Havn't tested under different event loops and for now only ran the tests on 3.10